Improving static analysis config

.github/workflows/abismal_build_macos.yml

@@ -8,24 +8,24 @@ on:
     branches: [ "master" ]
 
 jobs:
-  build-on-x86:
-    runs-on: macos-13
-    steps:
-    - uses: actions/checkout@v4
-      with:
-        submodules: recursive
-    - name: Update Homebrew
-      run: brew update
-    - name: Install automake
-      run: brew install automake
-    - name: Install dependencies
-      run: brew install htslib
-    - name: Generate configure script
-      run: ./autogen.sh
-    - name: configure with g++-14
-      run: ./configure CXX="g++-14" CPPFLAGS="-I$(brew --prefix)/include" LDFLAGS="-L$(brew --prefix)/lib"
-    - name: Build with g++-14
-      run: make -j4
+  # build-on-x86:
+  #   runs-on: macos-13
+  #   steps:
+  #   - uses: actions/checkout@v4
+  #     with:
+  #       submodules: recursive
+  #   - name: Update Homebrew
+  #     run: brew update
+  #   - name: Install automake
+  #     run: brew install automake
+  #   - name: Install dependencies
+  #     run: brew install htslib
+  #   - name: Generate configure script
+  #     run: ./autogen.sh
+  #   - name: configure with g++-14
+  #     run: ./configure CXX="g++-14" CPPFLAGS="-I$(brew --prefix)/include" LDFLAGS="-L$(brew --prefix)/lib"
+  #   - name: Build with g++-14
+  #     run: make -j4
   build-on-arm64:
     runs-on: macos-15
     steps:

CMakeLists.txt

@@ -40,6 +40,18 @@ configure_file(data/config.h.in config.h)
 
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")
 
+add_compile_options(
+  -Wall
+  -Wextra
+  -Wpedantic
+  -Werror
+  -Wfatal-errors
+)
+
+if(NOT PROJECT_IS_TOP_LEVEL)
+  set(STATIC_ANALYSIS OFF)
+endif()
+
 if(STATIC_ANALYSIS)
   include(cmake/static_analysis.cmake)
 endif()

iwyu.json

@@ -1,2 +1,4 @@
 [
+    { "include": ["@[\"<]htslib/kstring.h[\">]", "private", "<htslib/sam.h>", "public"] },
+    { "include": ["@[\"<]htslib/hts.h[\">]", "private", "<htslib/sam.h>", "public"] },
 ]