test: make live /tools smoke test opt-in so it doesn't gate CI#18
Closed
smellouk wants to merge 1 commit into
Closed
test: make live /tools smoke test opt-in so it doesn't gate CI#18smellouk wants to merge 1 commit into
smellouk wants to merge 1 commit into
Conversation
The smoke test targets the live shellify.app/tools page, which a PR can't update before merge — so it would always fail on the PR that fixes the page. Gate it behind the runToolsSmokeTest instrumentation arg: skipped by default (CI green), run on demand with -e runToolsSmokeTest true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17.
toolsPage_selfClosingPopup_smoketargets the liveshellify.app/toolspage. Because a PR can't update the deployed page before it merges, the smoke test fails on CI whenever the live page hasn't yet been updated to theabout:blankpopup pattern (window.open()to adata:URL is blocked by Chromium → popup count stays 0). It shouldn't gate the build.This gates the test behind an instrumentation argument — skipped by default (CI green), runnable on demand:
The hermetic engine popup tests (self-close, opener round-trip, show/dismiss) are unchanged and keep running on every build.