add fast mcms package id to token pool deps#412
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Sui token-pool deployment/configuration changeset to require and propagate the fast (fastcurse) MCMS package ID into the token pool deployment inputs, ensuring token pools can be published with both the slow and fast MCMS dependencies.
Changes:
- Load
FastCurseMCMSPackageIDfrom on-chain state and inject it into BurnMint, LockRelease, and Managed token pool inputs. - Fail early (in
Apply) when the fast MCMS package is not present for the selected Sui chain. - Add a
VerifyPreconditionscheck to ensure the fast MCMS package is deployed before running the changeset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
217
to
229
| func (d DeployTPAndConfigure) VerifyPreconditions(e cldf.Environment, config DeployTPAndConfigureConfig) error { | ||
| state, err := deployment.LoadOnchainStatesui(e) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if state[config.SuiChainSelector].FastCurseMCMSPackageID == "" { | ||
| return fmt.Errorf( | ||
| "fast MCMS package not deployed for Sui chain %d; run DeploySuiChain first", | ||
| config.SuiChainSelector, | ||
| ) | ||
| } | ||
| return nil | ||
| } |
faisal-chainlink
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Describe highly relevant files or code snippets that are critical in the review
Are there other PRs that should be merged first?