map TXM FeeCharged to SubmitTransactionResponse.TransactionFee#132
Merged
Conversation
Soroban Contract Test Coverage93.20% line coverage — 18033 / 19348 lines hit
Per-Contract Breakdown
Full file-level coverage report |
silaslenihan
approved these changes
Jun 17, 2026
ilija42
requested changes
Jun 19, 2026
Comment on lines
+244
to
248
| if result.Fee != nil && result.Fee.IsUint64() { | ||
| fee := result.Fee.Uint64() | ||
| reply.TransactionFee = &fee | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
You also added block time stamp to the response struct, should that be filled in too?
|
Code coverage report:
|
ilija42
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the fee that TXM already tracks (FeeCharged from ResultXDR on confirmation) through to StellarService.SubmitTransaction callers.
Previously TxResult.Fee was computed but dropped. Now it flows to SubmitTransactionResponse.TransactionFee (stroops).