Support logTrigger in fake chain#1589
Merged
Merged
Conversation
Contributor
✅ API Diff Results -
|
silaslenihan
changed the title
silaslenihan
force-pushed
the
fake-chain-logtrigger
branch
from
July 16, 2026 19:28
caf429f to
bc7b45c
Compare
silaslenihan
marked this pull request as ready for review
July 16, 2026 19:44
product-security-plaid-production
Bot
requested review from
Farber98 and
patricios-space
July 16, 2026 19:44
silaslenihan
marked this pull request as draft
July 16, 2026 19:51
Contributor
|
silaslenihan
marked this pull request as ready for review
July 16, 2026 20:57
silaslenihan
force-pushed
the
fake-chain-logtrigger
branch
from
July 17, 2026 13:07
44627a8 to
90f8673
Compare
yashnevatia
previously approved these changes
Jul 20, 2026
ilija42
previously approved these changes
Jul 20, 2026
| t.Run("malformed program addresses are rejected", func(t *testing.T) { | ||
| t.Parallel() | ||
| fc := newTestSolanaChain(t, true) | ||
| _, cerr := fc.RegisterLogTrigger(ctx, triggerID, md, &solcap.FilterLogTriggerRequest{Address: []byte{0x01}}) |
Collaborator
There was a problem hiding this comment.
nit: use t.Context to scope context to current t.Run instead of using parent contex
| if len(sk.GetPath()) != 1 { | ||
| return fmt.Errorf("subkey path %v: only single-level (top-level scalar field) paths are supported in cre-cli simulate", sk.GetPath()) | ||
| } | ||
| fieldName, ok := resolveTopLevelFieldName(decoded, sk.GetPath()[0]) |
Collaborator
There was a problem hiding this comment.
Why is this needed? solcommoncodec.ExtractField supports nested fields and returns an error if one does not exist.
Also, is there normalization of the field name in logPoller? If not, the simulation will detect the event, but prod won't, which is a critical issue.
Unheilbar
previously approved these changes
Jul 21, 2026
silaslenihan
force-pushed
the
fake-chain-logtrigger
branch
from
July 21, 2026 13:35
46961a2 to
a91d92b
Compare
silaslenihan
force-pushed
the
fake-chain-logtrigger
branch
2 times, most recently
from
July 21, 2026 13:59
13e2f5f to
9abc1d4
Compare
silaslenihan
force-pushed
the
fake-chain-logtrigger
branch
from
July 21, 2026 14:00
9abc1d4 to
766d43a
Compare
dhaidashenko
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Requires Dependencies
Resolves Dependencies