Skip to content

Wire balance slot#1570

Merged
Unheilbar merged 2 commits into
feature/solcap-read_triggerfrom
wire_balance_slot
Jun 12, 2026
Merged

Wire balance slot#1570
Unheilbar merged 2 commits into
feature/solcap-read_triggerfrom
wire_balance_slot

Conversation

@Unheilbar

@Unheilbar Unheilbar commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Add nil guards for req.Opts in SolanaService
  • Wire Slot for GetBalanceWithCommitment, GetFeeWithCommitment
  • Fix GetFeeWithCommitment, commitment field was ignored and ommited by SolanaService
    core ref: 64ff781233b2f4c06bf87d82d54c81f0360afe6f

@Unheilbar Unheilbar changed the base branch from develop to feature/solcap-read_trigger June 10, 2026 12:56
@github-actions

Copy link
Copy Markdown
Contributor

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-solana/contracts

View full report

@github-actions

Copy link
Copy Markdown
Contributor

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-solana/integration-tests

View full report

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-solana

⚠️ Breaking Changes (9)

pkg/solana/client.(*Client) (1)
  • BalanceWithCommitment — Type changed:
func(
  context.Context, 
  github.com/gagliardetto/solana-go.PublicKey, 
  github.com/gagliardetto/solana-go/rpc.CommitmentType
)
- (uint64, error)
+ (*github.com/gagliardetto/solana-go/rpc.GetBalanceResult, error)
pkg/solana/client.(*MultiClient) (1)
  • BalanceWithCommitment — Type changed:
func(
  context.Context, 
  github.com/gagliardetto/solana-go.PublicKey, 
  github.com/gagliardetto/solana-go/rpc.CommitmentType
)
- (uint64, error)
+ (*github.com/gagliardetto/solana-go/rpc.GetBalanceResult, error)
pkg/solana/client.AccountReader (1)
  • GetProgramAccountsWithOpts — ➕ Added
pkg/solana/client.Reader (2)
  • BalanceWithCommitment — Type changed:
func(
  context.Context, 
  github.com/gagliardetto/solana-go.PublicKey, 
  github.com/gagliardetto/solana-go/rpc.CommitmentType
)
- (uint64, error)
+ (*github.com/gagliardetto/solana-go/rpc.GetBalanceResult, error)
  • GetFeeForMessageWithCommitment — ➕ Added
pkg/solana/client/mocks.(*ReaderWriter) (1)
  • BalanceWithCommitment — Type changed:
func(
  context.Context, 
  github.com/gagliardetto/solana-go.PublicKey, 
  github.com/gagliardetto/solana-go/rpc.CommitmentType
)
- (uint64, error)
+ (*github.com/gagliardetto/solana-go/rpc.GetBalanceResult, error)
pkg/solana/client/mocks.(*ReaderWriter_BalanceWithCommitment_Call) (2)
  • Return — Type changed:
func(
  - uint64, 
  + *github.com/gagliardetto/solana-go/rpc.GetBalanceResult, 
  error
)
*ReaderWriter_BalanceWithCommitment_Call
  • RunAndReturn — Type changed:
func(
  func(context.Context, 
  github.com/gagliardetto/solana-go.PublicKey, 
  - github.com/gagliardetto/solana-go/rpc.CommitmentType) (uint64, 
  + github.com/gagliardetto/solana-go/rpc.CommitmentType) (*github.com/gagliardetto/solana-go/rpc.GetBalanceResult, 
  error)
)
*ReaderWriter_BalanceWithCommitment_Call
pkg/solana/config.Workflow (1)
  • RequestSizeLimit — ➕ Added

✅ Compatible Changes (15)

github.com/smartcontractkit/chainlink-common/pkg/types.(*UnimplementedRelayer) (1)
  • Stellar — ➕ Added
pkg/solana.(*solanaService) (1)
  • GetProgramAccounts — ➕ Added
pkg/solana.Relayer (1)
  • UnimplementedSolanaClient — ➕ Added
pkg/solana/client.(*Client) (2)
  • GetFeeForMessageWithCommitment — ➕ Added

  • GetProgramAccountsWithOpts — ➕ Added

pkg/solana/client.(*MultiClient) (2)
  • GetFeeForMessageWithCommitment — ➕ Added

  • GetProgramAccountsWithOpts — ➕ Added

pkg/solana/client.AccountReader (1)
  • GetProgramAccountsWithOpts — ➕ Added
pkg/solana/client/mocks (2)
  • ReaderWriter_GetFeeForMessageWithCommitment_Call — ➕ Added

  • ReaderWriter_GetProgramAccountsWithOpts_Call — ➕ Added

pkg/solana/client/mocks.(*ReaderWriter) (2)
  • GetFeeForMessageWithCommitment — ➕ Added

  • GetProgramAccountsWithOpts — ➕ Added

pkg/solana/client/mocks.(*ReaderWriter_Expecter) (2)
  • GetFeeForMessageWithCommitment — ➕ Added

  • GetProgramAccountsWithOpts — ➕ Added

pkg/solana/config.WorkflowConfig (1)
  • RequestSizeLimit — ➕ Added

📄 View full apidiff report

@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@Unheilbar Unheilbar marked this pull request as ready for review June 12, 2026 12:20
@Unheilbar Unheilbar requested review from a team as code owners June 12, 2026 12:20
@Unheilbar Unheilbar merged commit 29d5123 into feature/solcap-read_trigger Jun 12, 2026
52 of 62 checks passed
@Unheilbar Unheilbar deleted the wire_balance_slot branch June 12, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants