Skip to content

Redact send only node uri in logs #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amit-momin merged 2 commits into from
Jun 25, 2026
+3 −3
Merged

Redact send only node uri in logs #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
277ed49
Redacted send only node uri in logs
amit-momin Jun 24, 2026
c6666a6
Updated test
amit-momin Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion multinode/send_only_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func (s *sendOnlyNode[CHAIN_ID, RPC]) RPC() RPC {
}

func (s *sendOnlyNode[CHAIN_ID, RPC]) String() string {
return fmt.Sprintf("(%s)%s:%s", Secondary.String(), s.name, s.uri.Redacted())
return fmt.Sprintf("(%s)%s:%s", Secondary.String(), s.name, shortenURL(&s.uri))
}

func (s *sendOnlyNode[CHAIN_ID, RPC]) setState(state nodeState) (changed bool) {
Expand Down
4 changes: 2 additions & 2 deletions multinode/send_only_node_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func TestNewSendOnlyNode(t *testing.T) {
password := "pass"
u, err := url.Parse(fmt.Sprintf(urlFormat, password))
require.NoError(t, err)
redacted := fmt.Sprintf(urlFormat, "xxxxx")
shortened := shortenURL(u)
lggr := logger.Test(t)
name := "TestNewSendOnlyNode"
chainID := RandomID()
Expand All @@ -32,7 +32,7 @@ func TestNewSendOnlyNode(t *testing.T) {
assert.NotNil(t, node)

// Must contain name & url with redacted password
assert.Contains(t, node.String(), fmt.Sprintf("%s:%s", name, redacted))
assert.Contains(t, node.String(), fmt.Sprintf("%s:%s", name, shortened))
assert.Equal(t, node.ConfiguredChainID(), chainID)
}

Expand Down
Loading