Skip to content

Add filter name to QueryTrackedLogs #2115

Closed
silaslenihan wants to merge 12 commits into
feature/solcap-read_triggerfrom
PLEX-2773
Closed

Add filter name to QueryTrackedLogs #2115
silaslenihan wants to merge 12 commits into
feature/solcap-read_triggerfrom
PLEX-2773

Conversation

@silaslenihan

@silaslenihan silaslenihan commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

👋 silaslenihan, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (6)

pkg/types.(*UnimplementedSolanaService) (1)
  • QueryTrackedLogs — Type changed:
func(
  context.Context, 
  []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + string
)
([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, error)
pkg/types.SolanaService (1)
  • QueryTrackedLogs — Type changed:
func(
  context.Context, 
  []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + string
)
([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, error)
pkg/types/mocks.(*SolanaService) (1)
  • QueryTrackedLogs — Type changed:
func(
  context.Context, 
  []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + string
)
([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, error)
pkg/types/mocks.(*SolanaService_Expecter) (1)
  • QueryTrackedLogs — Type changed:
func(
  interface{}, 
  interface{}, 
  + interface{}, 
  interface{}
)
*SolanaService_QueryTrackedLogs_Call
pkg/types/mocks.(*SolanaService_QueryTrackedLogs_Call) (2)
  • Run — Type changed:
func(
  func(ctx context.Context, 
  filterQuery []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  - limitAndSort github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort)
  + limitAndSort github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + filterName string)
)
*SolanaService_QueryTrackedLogs_Call
  • RunAndReturn — Type changed:
func(
  func(context.Context, 
  []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  - github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort) ([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, 
  + github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + string) ([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, 
  error)
)
*SolanaService_QueryTrackedLogs_Call

✅ Compatible Changes (21)

pkg/capabilities/v2/chain-capabilities/solana.(*FilterLogTriggerRequest) (1)
  • GetIncludeReverted — ➕ Added
pkg/capabilities/v2/chain-capabilities/solana.FilterLogTriggerRequest (1)
  • IncludeReverted — ➕ Added
pkg/chains/solana (2)
  • ConvertGetAccountInfoRequestFromProto — ➕ Added

  • ConvertGetAccountInfoRequestToProto — ➕ Added

pkg/chains/solana.(*GetAccountInfoWithOptsRequest) (1)
  • GetIsExternal — ➕ Added
pkg/chains/solana.(*GetMultipleAccountsWithOptsRequest) (1)
  • GetIsExternal — ➕ Added
pkg/chains/solana.(*GetTransactionRequest) (1)
  • GetIsExternal — ➕ Added
pkg/chains/solana.(*QueryTrackedLogsRequest) (1)
  • GetFilterName — ➕ Added
pkg/chains/solana.(*SimulateTXRequest) (1)
  • GetIsExternal — ➕ Added
pkg/chains/solana.GetAccountInfoWithOptsRequest (1)
  • IsExternal — ➕ Added
pkg/chains/solana.GetMultipleAccountsWithOptsRequest (1)
  • IsExternal — ➕ Added
pkg/chains/solana.GetTransactionRequest (1)
  • IsExternal — ➕ Added
pkg/chains/solana.QueryTrackedLogsRequest (1)
  • FilterName — ➕ Added
pkg/chains/solana.SimulateTXRequest (1)
  • IsExternal — ➕ Added
pkg/http (3)
  • GetResponseSizeLimit — ➕ Added

  • LimitedTransport — ➕ Added

  • WithResponseSizeLimit — ➕ Added

pkg/types/chains/solana.GetAccountInfoRequest (1)
  • IsExternal — ➕ Added
pkg/types/chains/solana.GetMultipleAccountsRequest (1)
  • IsExternal — ➕ Added
pkg/types/chains/solana.GetTransactionRequest (1)
  • IsExternal — ➕ Added
pkg/types/chains/solana.SimulateTXRequest (1)
  • IsExternal — ➕ Added

📄 View full apidiff report

@silaslenihan silaslenihan marked this pull request as draft June 2, 2026 19:30
@silaslenihan silaslenihan changed the base branch from main to PLEX-2936/add-external-flag June 2, 2026 19:55
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

✅ API Diff Results - github.com/smartcontractkit/chainlink-common/pkg/chipingress

✅ Compatible Changes (31)

./ (9)
  • BatchOpt — ➕ Added

  • EventsToBatchWithOpts — ➕ Added

  • HeaderProviderConfig — ➕ Added

  • NewHeaderProvider — ➕ Added

  • PublishError — ➕ Added

  • PublishErrorCode — ➕ Added

  • PublishOptions — ➕ Added

  • Signer — ➕ Added

  • WithTransactionEnabled — ➕ Added

batch (8)
  • ErrCodeDomainMisconfiguration — ➕ Added

  • ErrCodeEncodeError — ➕ Added

  • ErrCodeResultsMismatch — ➕ Added

  • ErrCodeSchemaMissing — ➕ Added

  • ErrCodeUnknown — ➕ Added

  • ErrCodeValidationFailed — ➕ Added

  • PublishError — ➕ Added

  • WithTransactionEnabled — ➕ Added

pb (10)
  • PublishError — ➕ Added

  • PublishErrorCode — ➕ Added

  • PublishErrorCode_name — ➕ Added

  • PublishErrorCode_PUBLISH_ERROR_CODE_DOMAIN_MISCONFIGURATION — ➕ Added

  • PublishErrorCode_PUBLISH_ERROR_CODE_ENCODE_ERROR — ➕ Added

  • PublishErrorCode_PUBLISH_ERROR_CODE_SCHEMA_MISSING — ➕ Added

  • PublishErrorCode_PUBLISH_ERROR_CODE_UNKNOWN — ➕ Added

  • PublishErrorCode_PUBLISH_ERROR_CODE_VALIDATION_FAILED — ➕ Added

  • PublishErrorCode_value — ➕ Added

  • PublishOptions — ➕ Added

pb.(*CloudEventBatch) (1)
  • GetOptions — ➕ Added
pb.(*PublishResult) (1)
  • GetError — ➕ Added
pb.CloudEventBatch (1)
  • Options — ➕ Added
pb.PublishResult (1)
  • Error — ➕ Added

📄 View full apidiff report

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

✅ API Diff Results - github.com/smartcontractkit/chainlink-common/keystore

✅ Compatible Changes (1)

corekeys/ocr2key (1)
  • RawEVMOnChainPublicKey — ➕ Added

📄 View full apidiff report

@silaslenihan silaslenihan changed the title Add filter name Add filter name to QueryTrackedLogs Jun 2, 2026
Base automatically changed from PLEX-2936/add-external-flag to feature/solcap-read_trigger June 2, 2026 21:58
@silaslenihan silaslenihan deleted the PLEX-2773 branch June 3, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants