Skip to content

Update Browser title independent from rebuild.#668

Open
fabianbrandscheid wants to merge 8 commits into
slovnicki:masterfrom
fabianbrandscheid:master
Open

Update Browser title independent from rebuild.#668
fabianbrandscheid wants to merge 8 commits into
slovnicki:masterfrom
fabianbrandscheid:master

Conversation

@fabianbrandscheid

Copy link
Copy Markdown

Follow up PR from this: #652 because issue still exists.

@fabianbrandscheid

Copy link
Copy Markdown
Author

@slovnicki Can you take a look at the PR, when you find some time? :)

@stan-at-work

Copy link
Copy Markdown
Contributor

LGTM ✅

@slovnicki

Copy link
Copy Markdown
Owner

Hey @fabianbrandscheid 👋
Thank for the PR!

I see some issues, will look into it later today or tomorrow.

@fabianbrandscheid

Copy link
Copy Markdown
Author

@slovnicki Thank you!

When you need some help, feel free to contact me :)

@slovnicki

Copy link
Copy Markdown
Owner

@fabianbrandscheid I now fully understand the need for this functionality.
I've been able to create a use case where we need to update browser title and there is no other way except having html.document.title = title; in one's project.

The use case is when we are doing Beamer.of(context).update(... rebuild: false). Route information (URL) is updated correctly, but browser title not because it gets called only during build (which is a mistake).

This tells me we should call setTabTitle in updateand not inbuild` so I would rewrite this PR differently. Let me know if you're ok with me closing this and we can open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants