remote-viewer: Address review feedback from #11634#11706
Merged
Conversation
Member
ogoffart
commented
May 12, 2026
ogoffart
commented
- Mark VS Code remote preview commands as (Experimental)
- Remove unnecessary #[allow(dead_code)] on pub PreviewTarget variants
- Move connect/disconnect remote preview commands to connector/remote module
- Check document cache before reading from disk in send_files_to_preview
- Report connection errors to the editor via SendShowMessage
- Remove glob re-export of remote module to fix unused import warning
- Mark VS Code remote preview commands as (Experimental) - Remove unnecessary #[allow(dead_code)] on pub PreviewTarget variants - Move connect/disconnect remote preview commands to connector/remote module - Check document cache before reading from disk in send_files_to_preview - Report connection errors to the editor via SendShowMessage - Remove glob re-export of remote module to fix unused import warning
ogoffart
commented
May 12, 2026
| let future = remote.connect(addresses, port as u16); | ||
| crate::common::spawn_local(async move { | ||
| if let Err(err) = future.await { | ||
| let _ = preview_to_lsp_sender.send( |
Member
Author
There was a problem hiding this comment.
Note that this is hard to see in the diff as this is part of a move (Why can't github show the moves correctly) but i also changed this to send a error message to the client instead of ignoring the error.
ogoffart
changed the title
LeonMatthes
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.