feat: add echo cancellation and noise suppression for recoding - #2747
Open
sapphi-red wants to merge 2 commits into
Open
sapphi-red wants to merge 2 commits into
sapphi-red wants to merge 2 commits into
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds echo cancellation and noise suppression feature for the recoding feature.
I recently use the recoding feature to record a video for a talk. I first recorded while I was using a fan and noticed that the noise caused by the fan was on the video. This PR will help for that kind of cases.
The UI looks like this now:


The echo cancellation feature uses the browser built-in option (
MediaTrackConstraints::echoCancellation).The noise suppression feature uses the browser built-in option (
MediaTrackConstraints::noiseSuppression) or my@sapphi-red/web-noise-suppressorpackage. My package supports multiple backends, but I added RNNoise (a well-known model, used in OBS) and GTCRN (state-of-the-art one in lightweight models). In my experience, RNNoise and GTCRN works better than the browser built-in one. You can try it at https://web-noise-suppressor.sapphi.red/.