Release Candidate v6.15.0#1273
Open
ruck314 wants to merge 10 commits into
Open
Conversation
…PREFIX Match CMakeLists.txt by setting both BOOST_ROOT and Boost_ROOT so CMP0144 upper-case and mixed-case <PACKAGENAME>_ROOT lookups resolve identically in the downstream RogueConfig.cmake.in.
Use ${Python3_EXECUTABLE} instead of hard-coded python3 so the numpy
include path comes from the same interpreter find_package(Python3) selected,
matching CMakeLists.txt. Avoids picking up a different python3 on PATH in
multi-python / conda environments.
Sync RogueConfig.cmake.in dependency discovery with CMakeLists.txt
Frames are commonly sent from pure-C++ worker threads, so a Master::sendFrame() dispatch can reach an attached Slave::acceptFrame() with no GIL held -- Rogue neither acquires nor releases the GIL around the downstream dispatch. A pure-C++ Slave subclass needs no action, but one that constructs, manipulates, or destroys Python-wrapped objects (Boost.Python / pybind11 / NumPy) MUST hold the GIL while doing so (e.g. rogue::ScopedGil). Touching Python objects without the GIL races CPython's allocator/GC and can segfault in PyObject_GC_Del during teardown. Document this on both Slave::acceptFrame() and Master::sendFrame(), noting that the base Slave::acceptFrame() releases the GIL in its own body and that Python _acceptFrame() overrides always run under ScopedGil.
The handler formatter used %(msg)s, which renders record.msg -- the raw format
string -- so printf-style logging args were never substituted and records such
as log.info("Making device %s", name) were emitted as a literal "Making device
%s". Use %(message)s (record.getMessage()) so the args are applied.
Add a regression test that formats a record through the RootLogHandler that Root
attaches to the global pyrogue logger, asserts the formatter is explicitly
configured, and restores the logger's handlers for isolation -- so it fails if
Root regresses to %(msg)s rather than passing silently on logging's default
formatter.
Fix logging arg interpolation; document stream GIL contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description