Caio/modules#1337
Draft
caiowakamatsu wants to merge 5 commits into
Draft
Conversation
* Make EnTT consumable as C++ module * Added `ENTT_MODULE` CMake option enabling EnTT compilation as C++ module * Added `ENTT_USER_CONFIG` CMake option to be able to specify C++ config defines
Author
|
In favor of keeping this PR well scoped, I think an attempt to reconcile STL injection + modules should not be made here. Instead a separate PR should be done for that functionality. |
Owner
That's fair. We still need to fix the conflicts though, and thanks for pointing this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for finish the work @MilanBorovy started with #1290 to get C++ 20 modules working with EnTT.
I will rebase it against
wipdue to the STL injection changes causing a massive merge conflict.Original PR text
I've [@MilanBorovy] noticed that similar pull rq is already ongoing but seems to be dead for a few months.
Instead of exporting symbols in separate files, export macros are used (similar to how fmt does it).
By setting
ENTT_MODULECMake option to ON theEnTT::EnTTtarget becomes module library allowingEnTTto be consumed asimport entt;.Another option
ENTT_USER_CONFIGis added toCMake. It can be used to configure entt as on can't simply #define all configurations inside source with modules.Usage example:
entt_config.hpp
CMakeLists.txt
Some explanation of this would be nice to put in wiki, unfortunately I [@MilanBorovy] can't pull request changes to wiki AFAIK.