Skip to content

Markdown unknown tags#79

Merged
skatkov merged 3 commits into
mainfrom
markdown-unknown-tags
Jun 5, 2026
Merged

Markdown unknown tags#79
skatkov merged 3 commits into
mainfrom
markdown-unknown-tags

Conversation

@skatkov

@skatkov skatkov commented Jun 5, 2026

Copy link
Copy Markdown
Owner

I want to be able to control how html to markdown conversion works with this gem. This PR introduces a configurable attribute that will be passed to ReverseMarkdown gem

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new RDoc option to control how reverse_markdown handles unknown HTML tags when generating Markdown, with corresponding CLI/config documentation and tests to validate behavior and error handling.

Changes:

  • Introduces markdown_unknown_tags as an RDoc::Options setting (plus CLI flag --markdown-unknown-tags) and validates accepted modes.
  • Passes the configured unknown_tags mode through to ReverseMarkdown.convert during markdown generation.
  • Adds coverage for default behavior, each supported mode, CLI parsing, .rdoc_options hash loading, and YAML serialization cases; documents usage in the README and changelog.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/test_markdown_helpers.rb Adds tests and helper utilities to cover the new markdown_unknown_tags option across default/CLI/YAML behaviors.
README.md Documents the new option, accepted values, and .rdoc_options configuration.
lib/rdoc/generator/markdown.rb Implements the option plumbing (RDoc::Options extension, CLI registration, validation) and wires unknown_tags: into ReverseMarkdown.convert.
CHANGELOG.md Records the addition of the new markdown_unknown_tags option.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@skatkov skatkov merged commit 67f1ce1 into main Jun 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants