Skip to content

feat(Card): add ghost variant with transparent background and no border#265

Merged
osohyun0224 merged 1 commit into
devfrom
feature/card-to-improve-osohyun0224
Apr 29, 2026
Merged

feat(Card): add ghost variant with transparent background and no border#265
osohyun0224 merged 1 commit into
devfrom
feature/card-to-improve-osohyun0224

Conversation

@osohyun0224
Copy link
Copy Markdown
Member

Fixed #264

Changes

Card 컴포넌트에 ghost variant를 추가했습니다. 실제 SIPE 공식 홈페이지 코드로도 테스트 완료했습니다!

  • Card.css.ts: CardVariantghost 옵션 추가 (배경색: transparent, border: none, padding: 0)
  • Card.test.tsx: ghost variant에 대한 테스트 3개 추가 (배경색, border, padding 검증)
  • Card.stories.tsx: argTypes에 ghost 옵션 추가 및 GhostVariant 스토리 추가 (모든 ratio 조합 포함)
  • .changeset/add-card-ghost-variant.md: @sipe-team/card minor 버전 changeset 추가

Visuals

Checklist

  • Have you written the functional specifications?
  • Have you written the test code?

Additional Discussion Points

  • ghost variant는 배경과 테두리가 없는 투명한 카드로, 레이아웃 용도나 콘텐츠만 감싸는 경우에 활용할 수 있습니다.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • release/v1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b2b7dea2-13a3-4357-a8dc-ec437a2122fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/card-to-improve-osohyun0224

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 28, 2026

🦋 Changeset detected

Latest commit: 18cd9aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sipe-team/card Minor
@sipe-team/side Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
packages/card/src/Card.css.ts 100.00% <ø> (ø)
packages/card/src/Card.test.tsx 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Yeom-JinHo Yeom-JinHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻

@osohyun0224 osohyun0224 merged commit 80eea39 into dev Apr 29, 2026
5 checks passed
@osohyun0224 osohyun0224 deleted the feature/card-to-improve-osohyun0224 branch April 29, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants