Skip to content

Adding new fields in schemas#33

Open
mmolimar wants to merge 1 commit into
singer-io:masterfrom
mmolimar:new-fields-schema
Open

Adding new fields in schemas#33
mmolimar wants to merge 1 commit into
singer-io:masterfrom
mmolimar:new-fields-schema

Conversation

@mmolimar

Copy link
Copy Markdown
Contributor

Description of change

I'm adding some missing fields in several entities in their JSON schemas.

Manual QA steps

  • JSON schema validation with the Intuit definition.

Risks

  • Just represents new fields in the JSON schemas.

Rollback steps

  • Revert this branch

@cmerrick

Copy link
Copy Markdown
Contributor

Hi @mmolimar, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick

Copy link
Copy Markdown
Contributor

You did it @mmolimar!

Thank you for signing the Singer Contribution License Agreement.

@mmolimar

Copy link
Copy Markdown
Contributor Author

},
"DiscountLineDetail": {
"properties": {
"ClassRef": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbshah1212 Please make a reference to the this object...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants