Upgrade python version, increase test coverage (#156)#159
Open
akkumar-qlik wants to merge 3 commits into
Open
Conversation
* Upgrade python version, increase test coverage * Updated tests, added spike * Update for datetime format * Update for datetime format * Update for bookmark tests * Update spike/seed_pipedrive.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * bookmark normalization * Update .circleci/config.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Addressed comments * Update tap_pipedrive/stream.py Co-authored-by: Rushikesh Todkar <98420315+RushiT0122@users.noreply.github.com> --------- Co-authored-by: Ranit Saha <ranit.saha@globallogic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Rushikesh Todkar <98420315+RushiT0122@users.noreply.github.com>
|
@copilot resolve the merge conflicts in this pull request |
Merge conflicts have been resolved in commit
All 96 unit tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade python version, increase test coverage
Updated tests, added spike
Update for datetime format
Update for datetime format
Update for bookmark tests
Update spike/seed_pipedrive.md
bookmark normalization
Update .circleci/config.yml
Addressed comments
Update tap_pipedrive/stream.py
Resolved merge conflicts with origin/master
Description of change
(write a short description or paste a link to JIRA)
Merged latest changes from
masterinto this branch to resolve conflicts. The following files had conflicts that were resolved:setup.py: Kept upgraded dependency versions (pendulum==3.2.0,requests==2.33.1,singer-python==6.8.0).tap_pipedrive/stream.py: Kept improved_normalize_bookmarkand_max_seen_bookmarkbookmark-tracking logic inPipedriveIncrementalStreamUsingSort.tests/test_pipedrive_bookmarks.py: Kept dynamic median-based simulated states approach.tests/test_pipedrive_start_date.py: Keptstart_date_2 = "2026-04-25T00:00:00Z".Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code