Skip to content

Add parent-tap-stream-id key in metadata#150

Open
MuralidharT03 wants to merge 8 commits into
masterfrom
SAC-28872-add-new-metadata
Open

Add parent-tap-stream-id key in metadata#150
MuralidharT03 wants to merge 8 commits into
masterfrom
SAC-28872-add-new-metadata

Conversation

@MuralidharT03

@MuralidharT03 MuralidharT03 commented Oct 21, 2025

Copy link
Copy Markdown

Description of change

This PR adds parent stream metadata tracking to the Pipedrivetap by introducing a new parent_attribute field to stream configurations and updating metadata generation to include parent-tap-stream-id information.

Ticket: SAC-28872

  • Added parent_attribute field to stream configurations in the flattened streams structure.
  • Updated metadata generation to include parent-tap-stream-id when a parent stream exists.

Changes

File Description
tap_pipedrive/tap.py Added parent_attribute field to both parent and child stream configurations
tap_pipedrive/tap.py Updated metadata generation to include parent-tap-stream-id for child streams
tap_pipedrive/streams/deal_products.py Added parent field to stream configurations
tap_pipedrive/streams/dealflow.py Added parent field to stream configurations

Manual QA steps

You need to comment out the authentication (auth) part in do_discovery, and generate a log file to verify the changes.

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@MuralidharT03 MuralidharT03 requested a review from Copilot October 23, 2025 05:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants