Skip to content

Support for null/empty org names in notes#104

Open
b-luu wants to merge 1 commit into
singer-io:masterfrom
b-luu:patch-1
Open

Support for null/empty org names in notes#104
b-luu wants to merge 1 commit into
singer-io:masterfrom
b-luu:patch-1

Conversation

@b-luu

@b-luu b-luu commented Sep 20, 2021

Copy link
Copy Markdown

Description of change

In natural (in the wild) Pipedrive usage, we can encounter Organization names that aren't (yet) filled in at the time a note is created on Pipedrive.
The current jsonschema rejects such records, which makes the whole sync fail and stop instantly !
Here we're expanding the support by adding null type to organization.name (sub)property.

Manual QA steps

  • Went through the data to understand what was happening
  • Found quite a few records matching "organization.name is null"

Risks

  • (slightly) more lenient schema validation (but that's the whole point here...)

Rollback steps

  • revert this branch

In natural (in the wild) Pipedrive usage, we can encounter Organization names that aren't (yet) filled in at the time a note is created on Pipedrive.
The current jsonschema rejects such records, which makes the whole sync fail and stop instantly !
Here we're expanding the support by adding null type to organization.name (sub)property.
@cmerrick

Copy link
Copy Markdown
Contributor

Hi @b-luu, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick

Copy link
Copy Markdown
Contributor

You did it @b-luu!

Thank you for signing the Singer Contribution License Agreement.

@b-luu

b-luu commented Sep 27, 2021

Copy link
Copy Markdown
Author

Hello @luandy64

Can you have a quick look please ?

This is litterally a oneliner and only touches one schema file.
While it's a blocker on my end to be able to use the Pipedrive connector correctly on Stitch...

Thanks !!

Cheers,
Brice

@b-luu

b-luu commented Oct 25, 2022

Copy link
Copy Markdown
Author

Hey @cmerrick

What's the process to have this merged ?

Thanks for your help!

Cheers,
Brice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants