Add backoff on calls to login fn#6
Open
KAllan357 wants to merge 1 commit into
Open
Conversation
dmosorast
suggested changes
May 6, 2020
dmosorast
left a comment
dmosorast
left a comment
Contributor
There was a problem hiding this comment.
Makes sense, I think the retry pattern is good, just one change.
| response.raise_for_status() | ||
| # 5xx errors should be retried | ||
| if response.status_code >= 500: | ||
| raise Pardot5xxError() |
Contributor
There was a problem hiding this comment.
I think we still want to maybe raise_for_status after the _check_error call below, to catch any statuses that we don't know about yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
In a busy Pardot API scenario, its possible for the call to login to be rate limited. This is an attempt to retry those errors.
Manual QA steps
Risks
Rollback steps