Skip to content

SAC-28869: Add parent-tap-stream-id metadata#54

Open
luandy64 wants to merge 7 commits into
SAC-30930-un-auth-streams-should-exclude-from-catalog-while-discoveryfrom
SAC-28869-add-parent-metadata
Open

SAC-28869: Add parent-tap-stream-id metadata#54
luandy64 wants to merge 7 commits into
SAC-30930-un-auth-streams-should-exclude-from-catalog-while-discoveryfrom
SAC-28869-add-parent-metadata

Conversation

@luandy64

@luandy64 luandy64 commented Oct 6, 2025

Copy link
Copy Markdown

Description of change

This PR writes parent-tap-stream-id to the catalog

Manual QA steps

  • ran discovery before and after the change. Here's the diff
CleanShot 2025-10-06 at 11 27 18@2x

Risks

  • Low. This is new-to-this-tap metadata so nothing should break because of this.

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Comment thread tests/tap_combined_test.py Outdated
stream_id = catalog["tap_stream_id"]

# Get the annotated schema to access metadata
schema_and_metadata = menagerie.get_annotated_schema(conn_id, catalog['stream_id'])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schema_and_metadata = menagerie.get_annotated_schema(conn_id, catalog['stream_id'])
schema_and_metadata = menagerie.get_annotated_schema(conn_id, stream_id)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated now

@RushiT0122

Copy link
Copy Markdown

Closing this PR since this is already take care of in PR#56

@RushiT0122 RushiT0122 closed this Jun 8, 2026
@RushiT0122

Copy link
Copy Markdown

Reopening this PR, since only replication method changes went into PR#56.

@RushiT0122 RushiT0122 reopened this Jun 12, 2026
@RushiT0122 RushiT0122 changed the base branch from master to SAC-30930-un-auth-streams-should-exclude-from-catalog-while-discovery June 12, 2026 08:55
…hile-discovery' into SAC-28869-add-parent-metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants