Skip to content

copy of pr#15 with merge conflicts resolved #29

Merged
leslievandemark merged 7 commits into
masterfrom
immuta-master
Jun 14, 2021
Merged

copy of pr#15 with merge conflicts resolved #29
leslievandemark merged 7 commits into
masterfrom
immuta-master

Conversation

@leslievandemark

@leslievandemark leslievandemark commented Jun 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of change

copy of @jdarrell's pr with merge conflicts resolved.

  • The Visitors call has an additional parameter called only_identified that defaults to true. When it is true it only pulls visitor_ids for "identified" visitors, which means visitors that eventually became prospects. So by default the API call pulls a subset of all site visitors.
  • The Visits endpoint required that the list of input visitor_ids not have spaces between them.

Manual QA steps

  • Ran the tap locally, confirmed that the total number of visitors matched what was seen in the Pardot UI for our account.

Risks

  • None that I can see.

Rollback steps

  • revert this branch

@leslievandemark leslievandemark changed the title Immuta master copy of [pr](https://github.com/singer-io/tap-pardot/pull/15) with merge conflicts resolved Jun 14, 2021
@leslievandemark leslievandemark changed the title copy of [pr](https://github.com/singer-io/tap-pardot/pull/15) with merge conflicts resolved copy of pr#15 with merge conflicts resolved Jun 14, 2021
@leslievandemark leslievandemark merged commit 06828fa into master Jun 14, 2021
@leslievandemark leslievandemark deleted the immuta-master branch June 14, 2021 19:37
This was referenced Jun 14, 2021
Merged
Merged
leslievandemark added a commit that referenced this pull request Jun 15, 2021
@leslievandemark
Revert "copy of pr#15 with merge conflicts resolved (#29)"
7e4f5b1 
This reverts commit 06828fa.
leslievandemark added a commit that referenced this pull request Jun 15, 2021
@leslievandemark
Revert to v1.3.1 (#36)
b8d6640 
* Revert "Call join correctly (#34)"

This reverts commit 76f8b3c.

* Revert "changed parent id parameter to a function for different streams (#32)"

This reverts commit 85fc3ad.

* Revert "copy of pr#15 with merge conflicts resolved  (#29)"

This reverts commit 06828fa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachharris1 zachharris1 zachharris1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leslievandemark @zachharris1 @jdarrell