Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bhtowles
reviewed
Jun 11, 2026
|
|
||
| class NotionNestedHierarchyTest(NotionBaseTest): | ||
| """ | ||
| Validate parent-child-grandchild replication integrity for Notion. |
There was a problem hiding this comment.
It seems like this test relies on the shape of the existing data in the source. I'm not sure if there are implications here with data aging out over time. This is an awesome start but I think we should note that the setup here is outside of the test and manual (making sure the parent-child-grandchild data is already set up in the source for those 3 streams). Notion also has a robust client, so a future project could be to transition this test to a CRUD test using the client to set up and then clean up the source data.
Author
There was a problem hiding this comment.
I want to get a little more on this. Lets discuss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
https://qlik-dev.atlassian.net/browse/SAC-31252
What does this PR do?
The PR contains new tests that were added to handle nested child and grandchild data for tap-notion. The tests recursively checks for blocks and block child and their grandchild data and ensure the data is being replicated and not omitted.
pages,blocks,block_childrenpagesrecord is replicatedblocksrecord is linked to a replicated pageType of change
Related issues
https://qlik-dev.atlassian.net/browse/SAC-31184
Checklist