SAC-28847: Add parent-tap-stream-id key in metadata#84
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for tracking parent-child relationships between streams by including a parent-tap-stream-id key in the metadata. This enables better understanding of stream hierarchies during data discovery operations.
- Added logic to detect parent stream relationships and store parent stream ID in metadata
- Enhanced metadata with parent-tap-stream-id field when a parent stream exists
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RushiT0122
left a comment
RushiT0122
left a comment
There was a problem hiding this comment.
Update discovery integration tests.
Added tests in the latest commit |
RushiT0122
left a comment
RushiT0122
left a comment
There was a problem hiding this comment.
Approving this PR but update tap version to minor.
| "admins": { | ||
| self.PRIMARY_KEYS: {"id"}, | ||
| self.REPLICATION_METHOD: self.FULL_TABLE, | ||
| self.EXPECTED_PARENT_STREAM: "admin_list", |
There was a problem hiding this comment.
While testing this tap found Admin_List as parent stream but we don't have schema for it.
| * Adds parent-tap-stream-id field to catalog for child streams [#84](https://github.com/singer-io/tap-intercom/pull/84) | ||
| # 2.2.5 |
There was a problem hiding this comment.
| * Adds parent-tap-stream-id field to catalog for child streams [#84](https://github.com/singer-io/tap-intercom/pull/84) | |
| # 2.2.5 | |
| * Adds parent-tap-stream-id field to catalog for child streams [#84](https://github.com/singer-io/tap-intercom/pull/84) | |
| # 2.2.5 |
Description of change
Adds support for tracking parent-child relationships between streams by including a
parent-tap-stream-idkey in the metadata. This enables better understanding of stream hierarchies during data discovery operations.Jira: SAC-28847
Manual QA steps
tap-intercom --config config.json --discover)conversation_partsstream contains"parent-tap-stream-id": "conversations"in its catalog metadataRisks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code