Change integer types to number in tracking_value_requests schema#51
Open
faina-smalls wants to merge 1 commit into
Open
Change integer types to number in tracking_value_requests schema#51faina-smalls wants to merge 1 commit into
faina-smalls wants to merge 1 commit into
Conversation
Fix: Change discount percentage fields from integer to number in tracking_value_requests schema
The Impact API returns decimal percentage values (e.g., 7.4%) but the schema incorrectly defined discount_percent and related fields as integer type, causing sync failures when encountering non-whole number percentages.
Changed the following fields from integer to number:
- bogo_get_discount_percent
- discount_maximum_percent
- discount_percent
- discount_percent_range_end
- discount_percent_range_start
This completes the schema fix across all affected tables (deals, promo_codes, and tracking_value_requests) and aligns with the correct definition in ads.json.
Part of fix for: "discount_percent: 7.4 does not match {'type': ['integer', 'null']}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Change discount percentage fields from integer to number in tracking_value_requests schema
The Impact API returns decimal percentage values (e.g., 7.4%) but the schema incorrectly defined discount_percent and related fields as integer type, causing sync failures when encountering non-whole number percentages.
Changed the following fields from integer to number:
This completes the schema fix across all affected tables (deals, promo_codes, and tracking_value_requests) and aligns with the correct definition in ads.json.
Part of fix for: "discount_percent: 7.4 does not match {'type': ['integer', 'null']}"