Added None check in deserialize.py#42
Open
b-moynihan wants to merge 2 commits into
Open
Conversation
…ge is not found on the stream record resulting in an attempt to deserialize the items on NoneType ie. `{'M': None}` now calls as `{'Null':True}` instead.
Contributor
|
Hi @b-moynihan, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Contributor
|
You did it @b-moynihan! Thank you for signing the Singer Contribution License Agreement. |
Author
|
@cmerrick @KAllan357 @asaf-erlich @cosimon I've posted this PR to the tap-dynamodb slack channel however it is very quiet over there. So I'm also tagging you here to notify you of a pending review for this PR. |
Contributor
|
cc @dmosorast |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids the scenario where NewImage is not found on the stream record resulting in an attempt to deserialize the items on NoneType ie. {'M': None} now calls as {'Null':True} instead.
Description of change
See issue #30 for details on fix
Manual QA steps
Configure DynamoDB Stream with StreamViewType : "KEYS_ONLY". Configure LOG_BASED Stitch extraction of DynamoDB stream.
When the extraction fails the following error message should be seen: Dynamo stream view type must be either "NEW_IMAGE" "NEW_AND_OLD_IMAGES NOT Extraction failed for ‘NoneType’ object has no attribute ‘items'
Risks
Rollback steps
Additional Info
This is actually a duplicate PR to #31 however this PR was closed as I deleted the linked Github account and didn't transfer the repo to my new account before hand.