Exclude unauthorized streams from catalog#58
Open
MuralidharT03 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the tap’s discovery flow to exclude streams the provided AppsFlyer credentials cannot read, by probing each stream during discovery and pruning inaccessible streams from the generated Singer catalog.
Changes:
- Add per-stream access probing (
BaseStream.check_access()+Client.probe_request()) and exclude inaccessible streams during discovery. - Update CLI discovery wiring to pass the active
Clientinto discovery. - Add unit tests covering access checks, pruning logic, and
do_discover()output.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unittests/test_discovery.py | Adds unit tests for discovery access checks, pruning behavior, and do_discover() integration. |
| tap_appsflyer/streams/abstracts.py | Introduces BaseStream.check_access() to probe stream accessibility. |
| tap_appsflyer/discover.py | Applies access checks during discovery and prunes inaccessible streams/children from the catalog. |
| tap_appsflyer/client.py | Adds probe_request() for single-shot discovery probes. |
| tap_appsflyer/init.py | Passes client through do_discover() into discover(client). |
| setup.py | Bumps package version, changes requests pin, and adds dev extras. |
| .github/copilot-instructions.md | Adds internal contributor guidance for implementing Singer taps/targets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR updates the tap’s discovery flow to exclude streams the provided AppsFlyer credentials cannot read, by probing each stream during discovery and pruning inaccessible streams from the generated Singer catalog.
Changes:
BaseStream.check_access()+Client.probe_request()) and exclude inaccessible streams during discovery.Clientinto discovery.do_discover()output.Jira: SAC-30993
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code