test: loosen TestHandshakeMultipleClients timeout from 5s to 30s#114
Merged
Conversation
The test opens five clients sequentially and waits on a buffered channel for five AcceptEnds to complete. The hardcoded 5-second deadline is tight under CI race + coverage: a recent post-merge run on main only got 4/5 through before giving up. Lifting the budget to 30s keeps the intent (catch a genuine deadlock, not a slow scheduler) without retriggering on warm runners. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The chaos suite has grown past the old ~3 minute budget: HalfOpenSendOnly (~94s), HalfOpenRecvOnly (~30s), NetworkBlackhole (~33s) and WireBitFlip (~105s) alone already sum to ~260s, with the rest of the suite bringing cumulative time to ~5 minutes on a warm runner. This PR showed a run at 296s — 4 seconds shy of the 300s wall — where every individual test passed but the binary got killed. Doubling the budget to 600s restores headroom without enabling genuinely hung tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestHandshakeMultipleClientshas a hardcoded 5s budget for five sequential handshakes. Under CI race + coverage the post-merge run on main only got 4/5 through, failing astimeout: only 4/5 accepted.Test plan
go test -count=5 -run TestHandshakeMultipleClients ./test/unit/...passes in ~3s locally.🤖 Generated with Claude Code