Skip to content

[Action] Apply passive chain multiplier modifiers without chain targets #11924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nnoggie wants to merge 1 commit into from
+6 −0
Closed

[Action] Apply passive chain multiplier modifiers without chain targets #11924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions engine/action/action.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,12 @@ void action_t::parse_effect_data( const spelleffect_data_t& spelleffect_data )
aoe = spelleffect_data.chain_target();
chain_multiplier = spelleffect_data.chain_multiplier();
}
// Spells that chain through class module target counts rather than their own chain targets, such as Scourge Strike
// with Clawing Shadows, still take passive chain multiplier modifiers without the base spell data value.
else if ( auto pct = player->get_passive_value( spelleffect_data, "chain_multiplier" )[ 2 ]; pct != 1.0 )
{
chain_multiplier = pct;
}

switch ( spelleffect_data.type() )
{
Expand Down