Repository navigation
Performance improvements - #160
Open
cosminpolifronie wants to merge 20 commits into
Open
cosminpolifronie wants to merge 20 commits into
cosminpolifronie wants to merge 20 commits into
Conversation
…they're not useful
…only handled end of route
…l Wiki information + additional routing bugfixes
…ittle to no heuristics are needed - generated routes are now also much more stable
…sn't fit the screen - now the popup will draw somewhere where it has space without moving the map
Not every station in the layer is a dispatch station. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ations"" The non-dispatch stations in that layer get their own "Passenger stations" layer instead. This reverts commit 136693d. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…CS icon with something more in the already existing style
…f the output data is the same
Joins were stored as geometry only, and the client drew each one in the colour of the leg before it, so a join crossing track that isn't in the game was drawn green. Joins now carry their colour runs (same format as segmentColors), which the client applies, reversed for joins drawn backwards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e don't get any flicker
The bearing was part of the marker's divIcon, so every position update of a moving train created a new icon and Leaflet rebuilt the marker's DOM, avatar image included. The icon now only changes with the avatar, selection or border state, and the arrow is rotated on the existing element. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every train marker was moved, drift-animated and given a permanent number tooltip on each 2-second update, including the ones far off-screen. Trains outside the view plus half a screen of margin on each side are now skipped; the selected train is always rendered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
These were bundled with the map although the signal and sneakpeek layers are off by default and the route data is only used once a route is shown. They're now dynamic imports: the layers load theirs the first time they're added to the map (LazyLayer; react-leaflet mounts overlay children even while unchecked, so mounting isn't the trigger), and the route data loads with the first route. check-routes.mjs now replaces the dynamic route data import when it runs the route code in Node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The unplayable, passenger and remote station markers built their L.icon inside the component, one per marker (~180 in total). The icon doesn't depend on the station, so each kind now shares one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (27)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #158 and #159, you can also take a look at the performance improvements made here.
They do make a big difference on less powerful mobile devices.