feat: implement SqliteDatabase#5
Merged
Merged
Conversation
pmorris-dev
commented
Nov 18, 2025
pmorris-dev
commented
Contributor
- Includes functions and tests for the database API
- Some tests also cover the functionality in registry.rs
velocitysystems
suggested changes
Nov 19, 2025
pmorris-dev
force-pushed
the
database_impl
branch
from
5af2bf3 to
1dff429
Compare
Contributor
Author
|
Okay, @velocitysystems. Looking forward to your review after this last round of discussion and changes. Thank you. |
- Includes functions and tests for the database API - Some tests also cover the functionality in registry.rs
pmorris-dev
force-pushed
the
database_impl
branch
from
1dff429 to
fe09dcb
Compare
velocitysystems
approved these changes
Nov 20, 2025
jjhafer
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.