Add global db registry#4
Merged
Merged
Conversation
velocitysystems
suggested changes
Nov 17, 2025
pmorris-dev
force-pushed
the
add_global_db_registry
branch
from
11b075d to
c253f60
Compare
Contributor
Author
|
@velocitysystems: Please see my replies and the amendments. Thank you. |
pmorris-dev
force-pushed
the
add_global_db_registry
branch
2 times, most recently
from
1ee33a1 to
f1875aa
Compare
velocitysystems
approved these changes
Nov 18, 2025
- This ensures only a single instance of a db (with is connection pools) can exist in the process - NOTE TO REVIEWERS: The caching behavior will be tested from the outside once the `database.rs` tests are committed.
pmorris-dev
force-pushed
the
add_global_db_registry
branch
from
f1875aa to
fa78d1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
database.rstests are committed (in an upcoming PR)