feat: add types to show API shape and design#3
Merged
Conversation
pmorris-dev
force-pushed
the
api_shape
branch
5 times, most recently
from
726084e to
7bbab2a
Compare
velocitysystems
suggested changes
Nov 13, 2025
velocitysystems
left a comment
velocitysystems
left a comment
Contributor
There was a problem hiding this comment.
Great work @1Cor125. Just a few observations and comments for your consideration.
pmorris-dev
force-pushed
the
api_shape
branch
from
7bbab2a to
b786564
Compare
- Once we have consensus on the API and types, I'll move on to implementation details and tests - Have to allow dead code and unused right now until we fully implement and test the API - Have to ignore doc tests temporarily for the same reason
pmorris-dev
force-pushed
the
api_shape
branch
from
b786564 to
173a296
Compare
Contributor
Author
|
Thanks for the helpful feedback, @velocitysystems. Check it out. I think we're good to go now. |
velocitysystems
approved these changes
Nov 14, 2025
velocitysystems
left a comment
velocitysystems
left a comment
Contributor
There was a problem hiding this comment.
Looks great @1Cor125. Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementation details and tests
implement and test the API