Skip to content

Lifecycle considerations#14

Merged
jjhafer merged 2 commits into
silvermine:masterfrom
pmorris-dev:lifecycle_considerations
Dec 17, 2025
Merged

Lifecycle considerations#14
jjhafer merged 2 commits into
silvermine:masterfrom
pmorris-dev:lifecycle_considerations

Conversation

@pmorris-dev

Copy link
Copy Markdown
Contributor
  • PRAGMA optimize on close
  • Clean up and close dbs on exit

@pmorris-dev

Copy link
Copy Markdown
Contributor Author

@jjhafer Here is one that can be reviewed when convenient. I won't worry about merging til I get back to this project in another couple weeks.

Comment thread src/lib.rs Outdated
Comment thread src/lib.rs Outdated
Comment thread src/lib.rs Outdated
@pmorris-dev pmorris-dev force-pushed the lifecycle_considerations branch 3 times, most recently from dd04636 to a1fa3d4 Compare December 16, 2025 21:37
- SQLite recommends running PRAGMA optimize on close to
   boost query perf so we will do what SQLite recommends :)
@pmorris-dev pmorris-dev force-pushed the lifecycle_considerations branch 2 times, most recently from 3729440 to 6774b4f Compare December 17, 2025 04:40
- This will close connections, truncate WAL files and
   drain the db cache
@pmorris-dev pmorris-dev force-pushed the lifecycle_considerations branch from 6774b4f to b75ae26 Compare December 17, 2025 05:19
@jjhafer jjhafer merged commit ca3407d into silvermine:master Dec 17, 2025
1 check passed
@pmorris-dev pmorris-dev deleted the lifecycle_considerations branch December 17, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants