Rust backend/CLI replacement (previously Go)#2010
Merged
Merged
Conversation
zefhemel
changed the title
zefhemel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described here #1987
This is largely a backport of code already built for SilverBullet+. The goal is to unify more of those code bases and reduce the number of technologies I need to manage from TypeScript + Go + Rust to just TypeScript and Rust. This should have the added benefit (although slight) of a more safe and performant backend. Also, honestly, often Rust code is nicer and less verbose than Go (although in other places it is not).
Also using this as an opportunity to clean up some rough edges and have more comprehensive test coverage.
While this seems to add 9k additional lines, this is actually largely a cargo.lock file and a lot more tests than the Go backend used to have, so net it's less server code (Rust is less verbose than Go).