Update X-Frame-Options header to SAMEORIGIN#434
Closed
ethancanne wants to merge 1 commit into
Closed
Conversation
ethancanne
requested review from
briskt,
forevermatt,
jason-jackson and
mtompset
and removed request for
a team
June 23, 2026 19:07
briskt
approved these changes
Jun 23, 2026
briskt
left a comment
briskt
left a comment
Contributor
There was a problem hiding this comment.
Are you aware of anything that was broken during the time this was set to DENY? Since it was like that for a while, maybe we don't need to use SAMEORIGIN after all.
Contributor
|
I didn't realize we recently set it to DENY. That is better than SAMEORIGIN. I'm checking with one other IdP owner to make sure DENY won't cause an issue for them. |
Contributor
|
Just heard back, leaving this at DENY is fine! No issues reported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDP-2036 Use "X-Frame-Options" header on ssp-base, set to SAMEORIGIN
Updates the X-Frame-Options HTTP response header configuration to SAMEORIGIN.
Changed (non-breaking)