Rollback Password Visibility Feature#427
Closed
ethancanne wants to merge 2 commits into
Closed
Conversation
ethancanne
requested review from
briskt,
forevermatt,
jason-jackson and
mtompset
and removed request for
a team
jason-jackson
approved these changes
Jun 9, 2026
forevermatt
approved these changes
Jun 10, 2026
forevermatt
left a comment
forevermatt
left a comment
Contributor
There was a problem hiding this comment.
I don't know what the code needs to be (given the conflict), but rolling this back for now seems like a good next step.
Contributor
Contributor
Author
|
Yeah, Jason and I were able to figure this out, but this was just a back up PR in case things didn’t work out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.