pin sigstore-python version used in custom_test#391
Open
bobcallaway wants to merge 1 commit into
Open
Conversation
Signed-off-by: Bob Callaway <bcallaway@google.com>
Member
|
Yeah, I don't object to the idea... but then we also need dependabot to ensure we test the latest release and that likely means dealing with the constant flood of dependency updates. There is an argument to be made that sigstore-python (the CLI) should act like a real application and should pin dependencies so that users don't have to... but sigstore-python is also a library that should not pin dependencies so we'd have to start doing two separate releases to implement that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this ensures we get a consistent resolution of all transitive deps