fix: scope hatch packages directive to wheel target only#637
Merged
mihaimaruseac merged 1 commit intoMay 30, 2026
Merged
Conversation
The packages directive was under [tool.hatch.build] (general), which applies to both wheel and sdist targets. Hatchling's sdist builder flattens the src-layout, placing model_signing/ at the archive root, but the embedded pyproject.toml still references src/model_signing — a path that no longer exists in the sdist. This causes pip to install an empty wheel with zero Python modules. Moving the directive to [tool.hatch.build.targets.wheel] lets the sdist target use hatchling's default behavior (preserve the full source tree including the src/ prefix), so the packages path matches the actual layout when installing from source distributions. Resolves: sigstore#636 Signed-off-by: Jon Burdo <jon@jonburdo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packages directive was under
[tool.hatch.build](general), which applies to both wheel and sdist targets. Hatchling's sdist builder flattens the src-layout, placing model_signing/ at the archive root, but the embedded pyproject.toml still references src/model_signing - a path that no longer exists in the sdist. This causes pip to install an empty wheel with zero Python modules.Moving the directive to
[tool.hatch.build.targets.wheel]lets the sdist target use hatchling's default behavior (preserve the full source tree including the src/ prefix), so the packages path matches the actual layout when installing from source distributions.Resolves: #636
Summary
This allows installation from sdist. I've tested with a script:
test-sdist.shThis fails on the current
main(7643e29):But is fixed on this branch:
Checklist