Skip to content

Delegate VariableList arbitrary impl to Vec<T>#82

Merged
macladson merged 1 commit into
sigp:mainfrom
macladson:improved-arbitrary
Mar 30, 2026
Merged

Delegate VariableList arbitrary impl to Vec<T>#82
macladson merged 1 commit into
sigp:mainfrom
macladson:improved-arbitrary

Conversation

@macladson
Copy link
Copy Markdown
Member

While #81 did help constrain list lengths, testing in sigp/lighthouse#9006 revealed that arbitrary VariableList lengths were still far too large.

A better approach is to delegate to arbitrary's own Vec<T> implementation, which constrains list lengths even more by using an iterative coin flip strategy. This keeps list lengths small enough to not immediately consume the whole buffer when constructing blocks.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.10%. Comparing base (fc690e9) to head (230bd46).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/variable_list.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   50.00%   50.10%   +0.10%     
==========================================
  Files          13       13              
  Lines         462      461       -1     
==========================================
  Hits          231      231              
+ Misses        231      230       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@macladson macladson requested a review from michaelsproul March 30, 2026 07:07
@macladson macladson merged commit f3fcb7e into sigp:main Mar 30, 2026
8 of 9 checks passed
@macladson macladson deleted the improved-arbitrary branch March 30, 2026 13:13
@macladson macladson mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants