Skip to content

SHIP-0047: Webhook TLS configuration flags#308

Merged
openshift-merge-bot[bot] merged 1 commit into
shipwright-io:mainfrom
anchi205:webhook-tls-config
May 29, 2026
Merged

SHIP-0047: Webhook TLS configuration flags#308
openshift-merge-bot[bot] merged 1 commit into
shipwright-io:mainfrom
anchi205:webhook-tls-config

Conversation

@anchi205

Copy link
Copy Markdown
Member

Changes

Proposal for webhook TLS defaults plus configurable CLI flags (--tls-min-version, --tls-cipher-suites) and a shared tls.Config builder used by the webhook and test servers.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

Proposal for webhook TLS defaults plus configurable flags (--tls-min-version, --tls-cipher-suites) and a shared tls.Config builder used by the webhook and test servers.

Signed-off-by: Anchita Borah <anborah@redhat.com>
@openshift-ci openshift-ci Bot requested a review from adambkaplan April 28, 2026 09:28
@pull-request-size pull-request-size Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 28, 2026
@openshift-ci openshift-ci Bot requested a review from SaschaSchwarze0 April 28, 2026 09:28

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Apr 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
@IrvingMg

Copy link
Copy Markdown
Member

/lgtm

Since this has been approved, LGTM to unblock.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 670116b into shipwright-io:main May 29, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Issues May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants