fix(e2e): use tag-based image references instead of nested repo paths#2208
Open
avinal wants to merge 1 commit into
Open
fix(e2e): use tag-based image references instead of nested repo paths#2208avinal wants to merge 1 commit into
avinal wants to merge 1 commit into
Conversation
Several e2e tests construct output image references as TEST_IMAGE_REPO/<testID>:latest, creating nested repository paths. This only works with registries that support arbitrary nested repos (e.g. ttl.sh). Registries like Quay.io and the OpenShift internal registry expect <namespace>/<repo>:<tag> and reject nested paths with 401/400 errors. Change to TEST_IMAGE_REPO:<testID> to match the pattern used by amendOutputImage in common_test.go, making TEST_IMAGE_REPO work consistently regardless of the registry backend Signed-off-by: Avinal Kumar <avinal@redhat.com>
openshift-ci
Bot
added
release-note-none
pull-request-size
Bot
added
the
size/M
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Several e2e tests construct output image references as
TEST_IMAGE_REPO/:latest, creating nested repository paths. This only
works with registries that support arbitrary nested repos (e.g. ttl.sh).
Registries like Quay.io and the OpenShift internal registry expect
/: and reject nested paths with 401/400 errors.
Change to TEST_IMAGE_REPO: to match the pattern used by
amendOutputImage in common_test.go, making TEST_IMAGE_REPO work consistently
regardless of the registry backend
Related Issue
Fixes #
Type of PR
/kind bug
Submitter Checklist