Conversation
…k-project#2970) A username ending in '.' combined with a subdomain-style site template (e.g. https://{username}.example.com) interpolates to an invalid URL such as https://alice..example.com, whose request raises and aborts the whole run. Validate the interpolated host with urlparse and report the site as ILLEGAL instead of crashing. Path-style templates (https://example.com/alice.) and valid FQDN usernames are unaffected. Fixes sherlock-project#2970
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2970.
A username ending in
.(e.g.alice.) combined with a subdomain template such ashttps://{username}.example.comproduces an invalid interpolated URLhttps://alice..example.com. The request layer raises on the malformed host and aborts the entire run, so one bad username kills discovery for every other site.Root cause
sitesentries whoseurlcontains{username}are interpolated before any host validation.urlparsethen yields a host with consecutive dots (..) or a leading dot, and the HTTP client raises while building the request.Fix
Before the regex/username check, validate the interpolated host with
urlparse:..in netloc, or.→ mark the site ILLEGAL and skip it instead of crashing the run.
Test
Added
tests/subdomain_username_test.py(regression):Files
sherlock_project/sherlock.pytests/subdomain_username_test.py