Repository navigation
ci(review): let core authors' reviews read the team issues a PR closes - #7405
Merged
Merged
Conversation
The issue token went to shellhub-io/admin authors only. A core member's PR that closes a team issue got the GITHUB_TOKEN fallback, whose closingIssuesReferences drops the team issue, so the Spec axis reported it unreadable and skipped (shellhub#7375, closing team#298). The admin-only gate keeps private team issue text out of public review comments on outsiders' fork PRs. Core members already have triage on shellhub-io/team, so the token shows them nothing new. Gate it on the same admin-or-core membership that lets an author request a /review.
|
Claude finished @otavio's task in 7s —— View job Code Review CompleteThe review did not run: this PR is already merged. The review procedure stops at pre-flight for closed, merged or draft PRs, so no Standards, Spec or Correctness pass ran and no inline comments were posted. This is not a clean result; the change has not been reviewed. Per the PR description, you can only check the gate change now by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review mints its issue token only for
shellhub-io/adminauthors. A core member's PR that closes a team issue falls back toGITHUB_TOKEN, whoseclosingIssuesReferencesdrops the team issue, so the Spec axis reports it unreadable and skips. That happened on #7375 (closes shellhub-io/team#298).The admin-only gate keeps private team issue text out of public review comments on outsiders' fork PRs. Core members already have triage on
shellhub-io/team, so the token shows them nothing new. The gate now uses the same admin-or-core check that lets an author request a/review.Cloud needs no change: it already mints the token for every author.
The workflow runs from
master, so it can only be checked after merge: a fresh/reviewon #7375 should list team#298 and run the Spec axis.