Repository navigation
chore(ui): keep knip off the Playwright output directory - #7400
Merged
Merged
Conversation
A Playwright run that fails writes its HTML report, trace viewer bundle included, under apps/console/e2e/tmp. knip then lists those .js and .css files as unused, and the React lint Stop hook refuses to end the turn until they are gone. The directory is gitignored output, so ignore it for knip too.
|
Claude finished @otavio's task in 56s —— View job Code Review CompleteReviewed 1 file on two axes: Standards (repo rules, language conventions, tests, code smells) and Correctness (security and runtime defects). No new issues found. The code looks good as-is. The Spec axis did not run because the PR references no issue to review against. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Playwright run that fails writes its HTML report under
ui/apps/console/e2e/tmp, and the report bundles the trace viewer's.jsand.cssfiles. knip then lists those files as unused, and the React lint Stop hook refuses to end the turn until they are deleted. The directory is gitignored output, so knip ignores it too."apps/console": { "entry": ["src/migrate.tsx", "playwright.config.ts"], - "ignore": ["src/client/**"], + "ignore": ["src/client/**", "e2e/tmp/**"],Split out of #7390, where it was outside the PR's scope.
Evidence
ui/scripts/e2e.sh testrun, knip reports the report'se2e/tmp/**/*.jsand*.cssfiles as unused.e2e/tmp. A clean checkout has no such directory, so CI's knip result does not change.Merge Danger
Door: two-way
Blast Radius: tooling
knip config only. No code ships.