[otavio]

Summary

The testcontainers suites and the console e2e suite ran only on the host, so every machine needed its own Go, Node, buildx and browser. On NixOS the browser Playwright downloads cannot start. exec server cannot run these suites either. It mounts part of the repo under /go/src, so the bind mounts in the suites' compose files resolve to nothing on the daemon.

./bin/docker-compose run --rm -T -w <dir> test go test ./...
  test   server development image, docker and buildx from docker:29.8.1-cli
         workspace mounted at its host path, the daemon's socket, host network
         the image's root, which rootless Docker maps to you
         Go and npm caches in the shellhub-tools-cache volume

ui/scripts/e2e.sh test [--edition=<edition>] [playwright args]
  stack up     in test
  playwright   in e2e: the official image at the version package-lock.json resolved,
               plus docker and the compose plugin from docker:29.8.1-cli

stack up exports the compose project as E2E_COMPOSE_PROJECT, and seed.ts requires it, so a Playwright run against a named stack seeds that stack and not shellhub-e2e-default. Both runners follow the rootless support on master. They mount SHELLHUB_DEV_DOCKER_SOCKET like the server does. e2e.sh stops with a pointer to SHELLHUB_ENV=development when the services are not loaded.

CI is unchanged. ui-e2e.yml sets E2E_RUNNER=host and keeps the runner's toolchain.

Evidence

• Before: these suites had no container path. On NixOS, npm run e2e:test failed with Chromium exiting 127 on libglib-2.0.so.0.
  After: each suite passes in the containers on a rootless daemon, through the wrapper with fix: check the ports the stack publishes in the rootless guard #7313, and the runs leave every file in the checkout owned by the user. The table's runs also passed earlier on a rootful daemon:

  Run	Result
  server/api/store/pg	ok
  tests/: TestLoginWithoutANamespace, TestDeviceListRefusesAStatusThePostgresEnumCannotHold	ok, images built with BuildKit
  cloud/pkg/store/pg with GOWORK=off	ok
  e2e.sh test auth.spec.ts	8 passed
  E2E_STACK_NAME=review e2e.sh test auth.spec.ts -g "removed member|signs in"	2 passed; the seeding helper reaches the named stack
  e2e.sh with no SHELLHUB_ENV=development	stops and names the setting
  bats tests/compose/	all ok; the wrapper only adds two exports

Merge Danger

Door: two-way

Blast Radius: dev tooling

• The server development image changes. Its docker CLI now comes from docker:29.8.1-cli instead of Alpine's package, and it gains buildx. Run ./bin/docker-compose build server.
• bin/docker-compose exports SHELLHUB_WORKSPACE and E2E_PLAYWRIGHT_VERSION, and Compose interpolates them for every service. The test and e2e services sit in the tools profile, so up never starts them.
• Development targets rootless Docker. On a rootful daemon the runners still work, but files they write in the checkout belong to root, as the rest of the dev stack's already do.
• Under rootless Docker, the wrapper's port guard from feat: run the dev stack under rootless Docker #7309 aborts every command in a worktree instance, these runners included. The cause is port 80, which an instance does not publish. fix: check the ports the stack publishes in the rootless guard #7313 fixes the guard. With it, on a rootless daemon, an integration test and e2e.sh test auth.spec.ts (8 specs) pass through the wrapper with the runners as root, and the checkout keeps your ownership.
• network_mode: host needs Docker Desktop's host networking on macOS.
• The enterprise and cloud e2e editions have not run in the containers yet. They need the license file, which the test service mounts from the env files, and the Stripe keys, which e2e.sh passes through.

[github-actions]

Code Review Complete

The automated review ran but did not post an updated summary — this usually means no new issues were found since the previous review. If you've pushed changes and want a fresh pass, comment /review.

View job