fix: preserve --exec-batch command order on arg flush#2061
Open
ychampion wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ychampion
force-pushed
the
fix-exec-batch-command-order
branch
from
bd9e365 to
15a7e01
Compare
Multiple --exec-batch commands should keep CLI order even when one command reaches the OS argument limit before the others. Flush all batch builders together at a shared boundary before pushing the next path. Constraint: The issue was maintainer-filed as sharkdp#2033 and the changelog requires behavior changes to be listed under the upcoming release. Rejected: Only documenting the exception | The surprising ordering can be fixed with a localized batch-boundary change. Confidence: high Scope-risk: narrow Directive: Keep --exec-batch commands aligned on shared flush boundaries when adding new batch-splitting rules. Tested: cargo test batch_command_order_is_preserved_when_argument_limit_flushes_one_command -- --nocapture; cargo test test_exec_batch -- --nocapture; cargo fmt --all -- --check; cargo test --all-features; cargo clippy --all-targets --all-features -- -Dwarnings; cargo +1.90.0 clippy --locked --all-targets --all-features; cargo +1.90.0 test --locked --all-features Not-tested: Cross-platform CI locally
ychampion
force-pushed
the
fix-exec-batch-command-order
branch
from
15a7e01 to
77e05f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--exec-batchcommands together when any command reaches a batch or argument-size boundaryWhy
Fixes #2033. Previously, if one batch command reached the OS argument limit before another, that later command could run before an earlier command from the CLI.
Validation
cargo test batch_command_order_is_preserved_when_argument_limit_flushes_one_command -- --nocapture— passed; failed before the fix withsecondbeforefirstcargo test test_exec_batch -- --nocapture— passedcargo fmt --all -- --check— passedcargo test --all-features— passedcargo clippy --all-targets --all-features -- -Dwarnings— passedcargo +1.90.0 clippy --locked --all-targets --all-features— passedcargo +1.90.0 test --locked --all-features— passedNotes