jwt-parser - show full date with timezone for date claims#412
Open
Lukkasss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Render the date-based JWT claims (
iat,exp,nbf) using the full date representation instead of a bare locale date + time.Before
iat (Issued At) 1516239022 (17/01/2018 23:30:22)
After
iat (Issued At) 1516239022 (Wed Jan 17 2018 23:30:22 GMT-0200 (Horário de Verão de Brasília))
Why
When investigating or debugging a JWT, the timestamp is often very important and displaying the full date right away helps a lot. The previous output (
17/01/2018 23:30:22) hid two things that matter for that analysis:GMT-0200), so you can immediately see how the token's time relates to UTC without doing the math in your head.Seeing the complete date picture lets you reason about a token's validity straight away instead of guessing what locale the short date was rendered in.
How
dateFormatternow returnsdate.toString()instead of${date.toLocaleDateString()} ${date.toLocaleTimeString()}.each user sees the timestamp in their own browser's timezone and language.
Notes about the change
src/tools/jwt-parser/jwt-parser.service.ts.iat,exp,nbf) since they share the same formatter.