Fix SS_PASSWORD environment variable being overwritten by parseURL#260
Open
MOON-CLJ wants to merge 1 commit into
Open
Fix SS_PASSWORD environment variable being overwritten by parseURL#260MOON-CLJ wants to merge 1 commit into
MOON-CLJ wants to merge 1 commit into
Conversation
The SS_PASSWORD environment variable was not working because parseURL() always overwrote the password variable, even when the URL contained no password. This caused the environment variable value to be lost. Changes: - Parse URL cipher and password into separate variables - Only override flag/env values when URL explicitly provides them - Apply fix to both client and server modes This allows proper priority: URL password > -password flag > SS_PASSWORD env var Fixes shadowsocks#249
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SS_PASSWORD environment variable was not working because parseURL() always overwrote the password variable, even when the URL contained no password. This caused the environment variable value to be lost.
Changes:
This allows proper priority: URL password > -password flag > SS_PASSWORD env var
Fixes #249