-
Notifications
You must be signed in to change notification settings - Fork 272
fix: Bump sglang version from 0.5.9 to 0.5.10 #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,7 +96,7 @@ class SGLangBackendArgs: | |
| sglang_enable_torch_compile: bool = True | ||
| sglang_enable_dp_attention: bool = False | ||
| sglang_enable_dp_lm_head: bool = False | ||
| sglang_enable_piecewise_cuda_graph: bool = False | ||
| sglang_enforce_piecewise_cuda_graph: bool = False | ||
| sglang_piecewise_cuda_graph_max_tokens: int = 4096 | ||
| sglang_piecewise_cuda_graph_tokens: List[int] = None | ||
| sglang_ep_size: int = 1 | ||
|
|
@@ -151,9 +151,9 @@ def add_args(parser: argparse.ArgumentParser) -> None: | |
| help="Enable piecewise CUDA graph for SGLang backend", | ||
| ) | ||
| parser.add_argument( | ||
| "--sglang-enable-piecewise-cuda-graph", | ||
| "--sglang-enforce-piecewise-cuda-graph", | ||
| action="store_true", | ||
| help="Enable piecewise CUDA graph for SGLang backend's prefill", | ||
| help="Enforce piecewise CUDA graph for SGLang backend's prefill", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The help text for the renamed argument |
||
| ) | ||
|
Comment on lines
153
to
157
|
||
| parser.add_argument( | ||
| "--sglang-piecewise-cuda-graph-max-tokens", | ||
|
|
@@ -186,7 +186,7 @@ def from_args(args: argparse.Namespace) -> "SGLangBackendArgs": | |
| sglang_enable_torch_compile=args.sglang_enable_torch_compile, | ||
| sglang_enable_dp_attention=args.sglang_enable_dp_attention, | ||
| sglang_enable_dp_lm_head=args.sglang_enable_dp_lm_head, | ||
| sglang_enable_piecewise_cuda_graph=args.sglang_enable_piecewise_cuda_graph, | ||
| sglang_enforce_piecewise_cuda_graph=args.sglang_enforce_piecewise_cuda_graph, | ||
| sglang_piecewise_cuda_graph_max_tokens=args.sglang_piecewise_cuda_graph_max_tokens, | ||
| sglang_piecewise_cuda_graph_tokens=args.sglang_piecewise_cuda_graph_tokens, | ||
| sglang_ep_size=args.sglang_ep_size, | ||
|
|
@@ -210,7 +210,7 @@ def to_kwargs(self) -> Dict[str, Any]: | |
| enable_torch_compile=self.sglang_enable_torch_compile, | ||
| enable_dp_attention=self.sglang_enable_dp_attention, | ||
| enable_dp_lm_head=self.sglang_enable_dp_lm_head, | ||
| enable_piecewise_cuda_graph=self.sglang_enable_piecewise_cuda_graph, | ||
| enforce_piecewise_cuda_graph=self.sglang_enforce_piecewise_cuda_graph, | ||
| piecewise_cuda_graph_max_tokens=self.sglang_piecewise_cuda_graph_max_tokens, | ||
| piecewise_cuda_graph_tokens=self.sglang_piecewise_cuda_graph_tokens, | ||
| ep_size=self.sglang_ep_size, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI help text for
--sglang-enable-dp-lm-headappears incorrect (it mentions piecewise CUDA graph). This is user-facing and may confuse users; update the help string to describe DP LM head behavior instead.